feat: removed result from testcase variables and removed errors warning and info from non verbose runs #617
Conversation
kilianpaquier
commented
Jan 27, 2023
•
kilianpaquier
commented
- removed ranged prints on non-verbose runs
- fixed info not interpolating right variable in step X with .result variable (was showing variable from X-1)
- print info before errors: closes Print info in current "step" before assertions #597
- on non-verbose runs, print info only when there're failures: closes Improving error debugging (especially in CI) #595
Signed-off-by: kpaquier <[email protected]>
…ue in teststep and show info before errors Signed-off-by: kpaquier <[email protected]>
Signed-off-by: Yvonnick Esnault <[email protected]>
|
revert. Intergration Tests are failing, example: |
Yes sorry, didn't see that one. It doesn't work anymore because I removed all .result from testcase variables. Only the assigned variables (coming from the key 'vars') are present in testcase variables, that's why interpolation.yaml doesn't fail. In my opinion, .result should be teststep scoped. If .result must be accessed later, then it should be assigned to a variable during the teststep. It is because every step computes a .result and if multiple steps are to compute .result.systemout, all of them would be stored in the testcase variables but only the last one would be used. In this case, result.systemout should be assign to a variable, and the comparison should be done with it. Just like it's done in interpolation.yaml. Another possibility is to prefix .result with the teststep name, like it is done on variable in different testcases. |
* Revert "feat: removed result from testcase variables and removed errors warning and info from non verbose runs (#617)" This reverts commit 0d936bf. * fix: revert #617 Signed-off-by: Yvonnick Esnault <[email protected]> * Update interpolate_once.yml --------- Signed-off-by: Yvonnick Esnault <[email protected]>
Hello @yesnault, what do you think ? |
…ng and info from non verbose runs (ovh#617) * feat: removed ranged stdout on non-verbose runs Signed-off-by: kpaquier <[email protected]> * feat: remove tc computedInfo, fix info not showing right variable value in teststep and show info before errors Signed-off-by: kpaquier <[email protected]> --------- Signed-off-by: kpaquier <[email protected]> Co-authored-by: kpaquier <[email protected]> Signed-off-by: Ivan Velasco <[email protected]>
* Revert "feat: removed result from testcase variables and removed errors warning and info from non verbose runs (ovh#617)" This reverts commit 0d936bf. * fix: revert ovh#617 Signed-off-by: Yvonnick Esnault <[email protected]> * Update interpolate_once.yml --------- Signed-off-by: Yvonnick Esnault <[email protected]> Signed-off-by: Ivan Velasco <[email protected]>
